Chrome debugger integration #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AObuchow
force-pushed
the
Chrome_debugger-integration
branch
3 times, most recently
from
ba6a6d6
to
1add0b5
Compare
Start packaging chrome debugger Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
Start refactorization of node/firefox/chrome debug adapter logic Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
Refactorings for debugTab's and variables used in DebugDelegates Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
Refactorings for debugTab's and DebugDelegates Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
AObuchow
force-pushed
the
Chrome_debugger-integration
branch
from
1add0b5
to
94805c8
Compare
| @@ -4,7 +4,8 @@ bin.includes = META-INF/,\ | |||
| .,\ | |||
| plugin.xml,\ | |||
| language-servers/package-lock.json,\ | |||
| language-servers/node_modules/,\ | |||
| language-servers/chrome-debug-adapter/extension/node_modules/,\ | |||
There was a problem hiding this comment.
We shouldn't have to do that if we can have the module treated as regular npm in node_modules.
| </arguments> | ||
| <workingDirectory>language-servers/</workingDirectory> | ||
| </configuration> | ||
| </execution> | ||
| </executions> | ||
| </plugin> | ||
|
|
There was a problem hiding this comment.
No need for those extra lines.
| @@ -0,0 +1,87 @@ | |||
| --- org.eclipse.wildwebdeveloper/src/org/eclipse/wildwebdeveloper/InitializeLaunchConfigurations.java | |||
There was a problem hiding this comment.
Seems like some garbage file
|
Can we close it as it seems like #256 replaces it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #230