fix_third_party: set install libdir and fix spdlog includes #570
Conversation
|
Hi @acastanedam, Thanks for the contribution. This all looks good. Also, please make sure you sign off all the commits with the same email as the email in your Eclipse account. Your git commit didn't have a signature yet. Thanks! |
|
The CI check failures above should be fixed in |
With the update of the third-party libraries, qcor's compilation crashes when try to link to the gtest and spdlog installed by xacc. This PR fix that and allows for compilation of qcor without touching qcor's configuration files.
acastanedam
force-pushed
the
fix_third_party
branch
from
7409455
to
6f9f41c
Compare
|
Hi @1tnguyen , excuse me for the delay. I've just re-based on the last master and push. |
CMakeLists.txt
Outdated
| @@ -60,6 +60,7 @@ set(CMAKE_SKIP_INSTALL_RPATH OFF) | |||
| set(CMAKE_SKIP_RPATH OFF) | |||
| set(CMAKE_INSTALL_RPATH_USE_LINK_PATH ON) | |||
| set(CMAKE_EXPORT_COMPILE_COMMANDS TRUE) | |||
| set(CMAKE_INSTALL_LIBDIR "${CMAKE_INSTALL_PREFIX}/lib") | |||
There was a problem hiding this comment.
Now I see a problem with this line :)
It should be placed after this block: https://github.com/eclipse/xacc/blob/master/CMakeLists.txt#L102-L106
(CMAKE_INSTALL_PREFIX is not set to a proper default value yet at this point. Our CI scripts all use this default hence didn't set it explicitly)
There was a problem hiding this comment.
I see. I've just moved the line. Thanks!
With the update of the third-party libraries, qcor's compilation
crashes when try to link to the gtest and spdlog installed by
xacc. This PR fix that and allows for compilation of qcor without
touching qcor's configuration files.