removed findbugs

eclipse · Mar 26, 2021 · 684a6fd · 684a6fd
1 parent 14f5588
commit 684a6fd
Show file tree

Hide file tree

Showing 6 changed files with 29 additions and 45 deletions.
diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
@@ -26,5 +26,5 @@ jobs:
       run: >
         xvfb-run
         mvn -f releng/org.eclipse.xsemantics.releng/pom.xml
-        clean verify -Dfindbugs.skip=true
+        clean verify
 
diff --git a/plugins/org.eclipse.xsemantics.dsl.ui/pom.xml b/plugins/org.eclipse.xsemantics.dsl.ui/pom.xml
@@ -29,10 +29,6 @@ Contributors:
 				<groupId>org.eclipse.xtend</groupId>
 				<artifactId>xtend-maven-plugin</artifactId>
 			</plugin>
-<!-- 			<plugin> -->
-<!-- 				<groupId>org.codehaus.mojo</groupId> -->
-<!-- 				<artifactId>findbugs-maven-plugin</artifactId> -->
-<!-- 			</plugin> -->
 		</plugins>
 	</build>
 </project>
diff --git a/plugins/org.eclipse.xsemantics.dsl/pom.xml b/plugins/org.eclipse.xsemantics.dsl/pom.xml
@@ -111,10 +111,6 @@ Contributors:
 				<artifactId>xtend-maven-plugin</artifactId>
 			</plugin>
 
-<!-- 			<plugin> -->
-<!-- 				<groupId>org.codehaus.mojo</groupId> -->
-<!-- 				<artifactId>findbugs-maven-plugin</artifactId> -->
-<!-- 			</plugin> -->
 		</plugins>
 	</build>
 

diff --git a/plugins/org.eclipse.xsemantics.runtime/pom.xml b/plugins/org.eclipse.xsemantics.runtime/pom.xml
@@ -29,10 +29,6 @@ Contributors:
 				<groupId>org.eclipse.xtend</groupId>
 				<artifactId>xtend-maven-plugin</artifactId>
 			</plugin>
-<!-- 			<plugin> -->
-<!-- 				<groupId>org.codehaus.mojo</groupId> -->
-<!-- 				<artifactId>findbugs-maven-plugin</artifactId> -->
-<!-- 			</plugin> -->
 		</plugins>
 	</build>
 </project>
diff --git a/releng/org.eclipse.xsemantics.parent/findbugs/old-findbugs.txt b/releng/org.eclipse.xsemantics.parent/findbugs/old-findbugs.txt
@@ -0,0 +1,28 @@
+		<findbugs-version>2.5.5</findbugs-version>
+
+				<plugin>
+					<groupId>org.codehaus.mojo</groupId>
+					<artifactId>findbugs-maven-plugin</artifactId>
+					<version>${findbugs-version}</version>
+					<configuration>
+						<skip>${findbugs.skip}</skip>
+						<findbugsXmlOutput>true</findbugsXmlOutput>
+						<failOnError>false</failOnError>
+						<!-- <findbugsXmlOutputDirectory>${findbugs.reportPath}</findbugsXmlOutputDirectory> -->
+						<!-- Enables analysis which takes more memory but finds more bugs. If 
+							you run out of memory, changes the value of the effort element to 'Low'. -->
+						<!-- <effort>Max</effort> -->
+						<!-- Low: Reports all bugs (other values are medium and max) -->
+						<!-- <threshold>Medium</threshold> -->
+						<maxRank>15</maxRank>
+						<jvmArgs>-Xmx1024m</jvmArgs>
+						<excludeFilterFile>${basedir}/../../releng/org.eclipse.xsemantics.parent/findbugs/excludeFilter.xml</excludeFilterFile>
+					</configuration>
+					<executions>
+						<execution>
+							<goals>
+								<goal>check</goal>
+							</goals>
+						</execution>
+					</executions>
+				</plugin>
diff --git a/releng/org.eclipse.xsemantics.parent/pom.xml b/releng/org.eclipse.xsemantics.parent/pom.xml
@@ -59,7 +59,6 @@ Contributors:
 		<maven-antrun-plugin.version>1.7</maven-antrun-plugin.version>
 		<junit-version>4.12</junit-version>
 		<jacoco-version>0.8.5</jacoco-version>
-		<findbugs-version>2.5.5</findbugs-version>
 		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
 		<maven.compiler.source>1.8</maven.compiler.source>
 		<maven.compiler.target>1.8</maven.compiler.target>
@@ -77,7 +76,6 @@ Contributors:
 		<swtbotTestsArgs>${uiTestsArgs} -Dorg.eclipse.swtbot.search.timeout=10000 -Dorg.eclipse.swt.internal.gtk.cairoGraphics=false</swtbotTestsArgs>
 
 		<!-- <jacoco.reportPath>../target/jacoco.exec</jacoco.reportPath> -->
-		<!-- <findbugs.reportPath>../target/findbugs</findbugs.reportPath>  -->
 
 		<!-- Sonar -->
 		<sonar.language>java</sonar.language>
@@ -115,7 +113,6 @@ Contributors:
 		 not in the git repository (since Sonarqube 5) -->
 		<sonar.scm.disabled>true</sonar.scm.disabled>		
 
-		<findbugs.skip>true</findbugs.skip>
 		<mwe2.skip>false</mwe2.skip>
 		<xtext.maven.skip>false</xtext.maven.skip>
 		<dsl.tests.skip>false</dsl.tests.skip>
@@ -161,7 +158,6 @@ Contributors:
 			<properties>
 				<xtext.maven.skip>true</xtext.maven.skip>
 				<skipTests>true</skipTests>
-				<findbugs.skip>true</findbugs.skip>
 				<!-- for Hudson CI @Eclipse.org -->
 				<!-- Disable this on your local machine -->
 				<cbi.jarsigner.skip>false</cbi.jarsigner.skip>
@@ -263,7 +259,6 @@ Contributors:
 			</activation>
 			<properties>
 				<skipTests>true</skipTests>
-				<findbugs.skip>true</findbugs.skip>
 			</properties>
 
 			<build>
@@ -388,33 +383,6 @@ Contributors:
 					</dependencies>
 				</plugin>
 
-				<plugin>
-					<groupId>org.codehaus.mojo</groupId>
-					<artifactId>findbugs-maven-plugin</artifactId>
-					<version>${findbugs-version}</version>
-					<configuration>
-						<skip>${findbugs.skip}</skip>
-						<findbugsXmlOutput>true</findbugsXmlOutput>
-						<failOnError>false</failOnError>
-						<!-- <findbugsXmlOutputDirectory>${findbugs.reportPath}</findbugsXmlOutputDirectory> -->
-						<!-- Enables analysis which takes more memory but finds more bugs. If 
-							you run out of memory, changes the value of the effort element to 'Low'. -->
-						<!-- <effort>Max</effort> -->
-						<!-- Low: Reports all bugs (other values are medium and max) -->
-						<!-- <threshold>Medium</threshold> -->
-						<maxRank>15</maxRank>
-						<jvmArgs>-Xmx1024m</jvmArgs>
-						<excludeFilterFile>${basedir}/../../releng/org.eclipse.xsemantics.parent/findbugs/excludeFilter.xml</excludeFilterFile>
-					</configuration>
-					<executions>
-						<execution>
-							<goals>
-								<goal>check</goal>
-							</goals>
-						</execution>
-					</executions>
-				</plugin>
-
 				<plugin>
 					<groupId>org.codehaus.mojo</groupId>
 					<artifactId>sonar-maven-plugin</artifactId>