This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
Add new Xtext editor quickfixes on *.xtext files #1523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing issue code in the method XtextValidator#checkTerminalFragmentCalledFromTerminalRule Updated the XtextLinkingDiagnosticMessageProvider Signed-off-by: nbhusare <neerajbhusare@gmail.com>
szarnekow
reviewed
Jun 22, 2020
| @@ -810,7 +810,7 @@ public void checkTerminalFragmentCalledFromTerminalRule(final RuleCall call) { | |||
| call, | |||
| XtextPackage.Literals.RULE_CALL__RULE, | |||
| ValidationMessageAcceptor.INSIGNIFICANT_INDEX, | |||
| null); | |||
| ILLEGAL_RULE_REFERENCE); | |||
There was a problem hiding this comment.
There are other validations, that appear to do similar validation, e.g. in line 796. Please use a more specific field name or provide an issue code for the other cases, too.
szarnekow
reviewed
Jun 22, 2020
| @@ -44,6 +44,7 @@ | |||
| public static final String BIDIRECTIONAL_REFERENCE = ISSUE_CODE_PREFIX + "BidirectionalReference"; | |||
| public static final String CROSS_REFERENCE_IN_ALTERNATIVES = ISSUE_CODE_PREFIX + "CrossReferenceInAlternatives"; | |||
| public static final String INVALID_FRAGMENT_AS_FIRST_RULE = ISSUE_CODE_PREFIX + "InvalidFragmentFirstRule"; | |||
| public static final String ILLEGAL_RULE_REFERENCE = ISSUE_CODE_PREFIX + "InvalidTerminalRuleCall"; | |||
There was a problem hiding this comment.
Maybe ILLEGAL_RULE_REFERENCE_IN_TERMINAL?
szarnekow
suggested changes
Jun 22, 2020
|
@szarnekow @nbhusare what is the current state of this PR? |
|
@cdietrich I'll be pushing the updated code today. |
|
@cdietrich I have raised another PR as I was facing some issues with this branch - #1540 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nbhusare neerajbhusare@gmail.com