Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

EclipseOutputConfigurationProvider.getOutputConfigurations(project) is inefficient #535

Closed
cdietrich opened this issue Jan 25, 2018 · 3 comments
Closed

EclipseOutputConfigurationProvider.getOutputConfigurations(project) is inefficient #535

cdietrich opened this issue Jan 25, 2018 · 3 comments
Assignees
@cdietrich
Labels
enhancement performance
Milestone
Release_2.14

Comments

@cdietrich
Copy link
Member

EclipseOutputConfigurationProvider.getOutputConfigurations(project) calls createAndOverlayOutputConfiguration over and over again. should not be done if preferences dont change
@cdietrich
Copy link
Member Author

@szarnekow @svenefftinge do know why this is not cached uring the build lifecycle of the (Parallel) Builder Participent

@svenefftinge
Copy link
Member

I don't know, sorry.

@szarnekow
Copy link
Contributor

I'd assume it's "just" an oversight.

cdietrich added a commit that referenced this issue Jan 25, 2018
@cdietrich
[#535] Add Cache for BuilderParticipant.getOutputConfigurations(IBuil…
8d10aac 
…dContext context)

Signed-off-by: Christian Dietrich <christian.dietrich@itemis.de>
@cdietrich cdietrich self-assigned this Jan 25, 2018
@cdietrich cdietrich mentioned this issue Jan 25, 2018
Merged
@cdietrich cdietrich added this to the Release_2.14 milestone Jan 25, 2018
kthoms pushed a commit that referenced this issue Jan 29, 2018
Merge pull request #536 from eclipse/cd_issue535
2b4547c 
[#535] Add Cache for BuilderParticipant.getOutputConfigurations(IBuildContext context)
@kthoms kthoms closed this as completed Jan 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cdietrich cdietrich

Labels
enhancement performance
Projects
None yet
Milestone
Release_2.14
Development

No branches or pull requests
4 participants
@cdietrich @kthoms @svenefftinge @szarnekow