Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

[#119] UX improvements for Generic IDE Support option #148

Merged
merged 4 commits into from Jan 4, 2017

Conversation

kthoms
Copy link

@kthoms kthoms commented Jan 2, 2017

The "Generic IDE Support" option is disabled whenever a UI plugin is selected. If
it was not enabled before, it will be selected automatically and an
information about this will be reported to the status widget.

Initial page: "Generic IDE Support" is disabled, since Eclipse Plugin is preselected.
screenshot 20

The option becomes enabled when Eclipse Plugin is deseleted.
screenshot 21

The option is deselected manually:
screenshot 22

The option "Web Support" is selected. The user is informed about the automatic selection of the "Generic IDE Support" option.
screenshot 23

Karsten Thoms added 4 commits January 2, 2017 15:45
The Generic IDE option is disabled whenever a UI plugin is selected. If
it was not enabled before, it will be selected automatically and an
information about this will be reported to the status widget.

Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
The Generic IDE option is disabled whenever a UI plugin is selected. If
it was not enabled before, it will be selected automatically and an
information about this will be reported to the status widget.

Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
@kthoms
Copy link
Author

kthoms commented Jan 3, 2017

The Generic IDE Support option is explained in an additional info decoration:

screenshot 24

if (autoSelectIdeProject) {
autoSelectIdeProject = false
reportIssue(INFORMATION, '''
'�createIdeProject.text�' project was automatically selected as option '�(source as Button).text�' requires it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overrides the message about the buildsystem, but the statusWidget can only show one message at once. For me that does not sound like a big issue but maybe other see that different.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside that the code works like expected and looks good to me.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, the status widget only stores one message at once. So if the user selects a project/build system combination that raises a message and then selects a UI project while Generic IDE was not selected so far, then the notice will overwrite the build system message. But the user has seen that message before.

Copy link
Contributor

@holgerschill holgerschill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As nobody posted a veto, I would say feel free to merge.

@kthoms kthoms merged commit 96ed73c into master Jan 4, 2017
@kthoms kthoms deleted the kth_issue119_ux_wizard branch January 4, 2017 13:34
@kthoms kthoms added this to the release_v2.11 milestone Jan 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants