This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
[UX] Consistent wizard message texts #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdietrich
reviewed
Jan 13, 2017
| @@ -8,37 +8,37 @@ | |||
| ############################################################################### | |||
|
|
|||
| NewXtextProjectWizard_WindowTitle=New Xtext Project | |||
| WizardNewXtextProjectCreationPage_Description=Click 'Finish' to create a basic Xtext Project or 'Next' to go to the advanced configuration | |||
| WizardNewXtextProjectCreationPage_Description=Click 'Finish' to create a basic Xtext project or 'Next' to go to the advanced configuration. | |||
There was a problem hiding this comment.
is still inconsistent case wise
| AdvancedNewProjectPage_ideaReqGradleInfo=IntelliJ Plugin requires Gradle build. An additional Gradle build will be created | ||
| AdvancedNewProjectPage_noBuildship=Gradle integration for eclipse is not installed. Consider to install Buildship. | ||
| AdvancedNewProjectPage_noM2e=Maven integration for eclipse is not installed. Consider to install M2e. | ||
| AdvancedNewProjectPage_Description=Customize your Xtext Project. |
There was a problem hiding this comment.
project should be lower case
| AdvancedNewProjectPage_noM2e=Maven integration for eclipse is not installed. Consider to install M2e. | ||
| AdvancedNewProjectPage_Description=Customize your Xtext Project. | ||
| AdvancedNewProjectPage_LabelFacets=Facets | ||
| AdvancedNewProjectPage_eclipseAndGradleWarn=Building Eclipse Plug-ins with Gradle is not yet supported. An additional Maven Tycho build will be created. |
There was a problem hiding this comment.
plug-ins should be lower case
- Sentences finished by dot. - Renamed WizardNewXtextProjectCreationPage_LabelFacets to AdvancedNewProjectPage_LabelFacets since it belongs to the advanced page. - Renamed 'Plugin' to 'plug-in'. This is how it is spelled in Eclipse wording. - Renamed 'eclipse' to 'Eclipse'. - 'Xtext Project' -> 'Xtext project' Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
kthoms
force-pushed
the
kt_wizard_messages
branch
from
df2c60d
to
745cb0f
Compare
|
@svenefftinge @cdietrich Is it OK now? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make the texts in the new project wizard more consistent.
AdvancedNewProjectPage_LabelFacets since it belongs to the advanced
page.
wording.