improved version of "fixVersions.sh"

[pngowda]

@kthoms @cdietrich
Hi
Here is the improved version of "fixVersionsScript.sh" .
could you please review this pull request. and let me know if some changes required.
Regards,
Prajwal

[cdietrich]

@pngowda can you please signoff the commit?

[kthoms]

For me the script takes long (>1min) when executed:

./fixVersions.sh -f 2.15.0
# from_version: 2.15.0
# to_version:
# 'to_version' is unset or set to the empty string
# deriving 'to_version' from 'from_verison'
# to_version: 2.16.0
# OS: Mac OS

It creates files with double quote at the end:

[kthoms]

Why was the PR closed?

[pngowda]

@kthoms @tivervac
could you please review.
have done some fixes as per the review comment. I use linux as my native OS, in that it the run time is not more than 2 sec. but in Mac its taking more time I have no clue.

[cdietrich]

hmm iplog bot is in a bad state again :(

[cdietrich]

https://bugs.eclipse.org/bugs/show_bug.cgi?id=540008

[cdietrich]

iplog (signoff email seems wrong)
we need to run the script on all repos.
have a look how other scripts use "allDirectories"

[tivervac]

@pngowda LGTM

[kthoms]

Can't specify Milestone/Release candidates
Target version would be for example 2.16.0.M1 or 2.16.0.RC1

[kthoms]

Also I'd expect that a development version would be specified with -SNAPSHOT suffix. How to distinguish between the dev and release version otherwise? For certain pom.xml the -SNAPSHOT must be removed for the final release, for others (used for Tycho builds) it has to stay.

[kthoms]

That said, I expect that it should be valid to execute with fixVersions.sh -f 2.16.0-SNAPSHOT -t 2.16.0.M1 or fixVersions.sh -f 2.16.0.RC1 -t 2.16.0

[cdietrich]

I would expect two scripts for that. I don’t think that can be done with one

[cdietrich]

I created the initial version exactly for the snapshot usecase Nothing else. Prajwal added the ask for versions you wanted to have

[kthoms]

The script only works in the umbrella repo. When I execute it in the directory of xtext-core, nothing happens. I miss a bit feedback which files are actually processed.

[cdietrich]

@kthoms see #84 (review)

[pngowda]

@kthoms @cdietrich

I discussed with Christian some time ago and I got to know that, there are different cases here.

snapshot to snapshot
milestone to snapshot
milestone to relase
release to snapshot
etc...

right now the script handles snapshot to snapshot(initial version from Christian) so, we need to finalize on these cases and define the set of files to be changed accordingly. then it would be easy for me to implement the script as generic as possible.

[szarnekow]

Is there still progress being made on this PR?

[pngowda]

right now it handles Snapshot to Snapshot bumping.need to define set of files to be changed for other cases.

[cdietrich]

@kthoms please review

obsolete

[kthoms]

Did not work (macOS)

./fixVersions.sh -f 2.16.0
# from_version: 2.16.0
# to_version:
# bump_to:
# 'to_version' is unset or set to the empty string
# deriving 'to_version' from 'from_verison'
# to_version: 2.17.0
./fixVersions.sh: line 121: [: ==: unary operator expected

[kthoms]

Please do not forget to squash & sign commit.

[cdietrich]

@kthoms please reexamine

[cdietrich]

@kthoms what is the state of the review?

[kthoms]

Failure on macOS:

Processing .../xtext-dev/git/xtext-maven
find: illegal option -- t
usage: find [-H | -L | -P] [-EXdsx] [-f path] path ... [expression]
       find [-H | -L | -P] [-EXdsx] -f path [path ...] [expression]

[kthoms]

Problem was usage of the currentDirectory property. This can be avoided when switching to the repository directory and then execute find on the current directory .. Makes the code also easier.

[kthoms]

Thanks @pngowda