Add new Xtend editor quickfixes on *.xtend files

[miklossy]

The Xtend IDE should provide the following quickfixes on *.xtend files:

• #398023
• #412593
• #454088

@loradd Would you like to take care of this issue?

[loradd]

Yes, I can take care of this. Thanks!

[loradd]

@miklossy it is not clear what is meant with constant in #454088, do we mean a final static instance member?

[miklossy]

Yes

[miklossy]

Currently, whenever the Xtend IDE recognizes that a method is missing, it offers a quickfix for creating the method:

It should be useful to offer an additional quickfix for creating a private method, in the example above there should be three quickfixes:

• Change to 'a'
• Create public method 'm'
• Create private method 'm'

@loradd Maybe you can fix this first.

[szarnekow]

@miklossy This should be discussed. I don't want to have quickfixes for all permutations of modifiers.

[miklossy]

@szarnekow I do not want to have quickfixes for all permutations of modifiers either. But creating a private method would be very useful, at least I would use that one more often than creating a public method. Currently I use the quickfix that creates a public method and have to modify that one to convert the created public method to private.

Let's see what others think about this.

[kthoms]

Creating a private method sounds as a likely choice. If this would be added I would not change the text for creating a public method, though.

[miklossy]

Hint: JDT offers a quickfix for creating a private method, but no quickfix to create a public one.

[szarnekow]

JDT uses placeholders in the proposed method.

[miklossy]

@szarnekow It is true:

Placeholders are nice to have, but I would be also fine with two different quickfixes.

[szarnekow]

Please note that there already two quickfixes Create method and Create extension method (the latter only, if there is an explicit receiver).
That would make it four quickfixes Create method, Create private method, Create extension method and Create private extension method.
I would object this kind of change for usability reasons. If you use the quickfix to create a method, you have to navigate to that method to create the body anyways.

[miklossy]

@szarnekow What about changing the already existing two quickfixes to create private methods instead of public ones?

[szarnekow]

@miklossy In Xtend, methods are public by default. Why should the quickfix create a non-default method? What would be a reasonable explanation for that behavior?

[miklossy]

I use Xtend mostly to define JUnit test cases. When following the TDD manner, it is a common way to create test helper methods in the test classes using that quickfix. Since the test helper methods are usually private, it would be useful to be able to create private method stubs using a quickfix.

Maybe we can unify the create method and the create extension method quickfixes into a single create method quickfix, since they create the same method stubs.

@cdietrich : What do you think?

[loradd]

@miklossy I am not able to reproduce issue #412593. The quickfix proposal concerns static members, not instance members, as expected. Could it be that the issue has already been solved?

[miklossy]

@loradd I can still reproduce the problem:

[szarnekow]

I reconsidered this. It would be ok for me if we offered Create private method and Create private extension along with the currently available quickfixes.

[miklossy]

@loradd How is the progress here?

[loradd]

@miklossy waiting for a second review on pull request #1068

[miklossy]

@cdietrich @szarnekow @ArneDeutsch @kthoms Could please someone review the PR?

[cdietrich]

@miklossy what is the state?

[miklossy]

I do not know the current state. Someone should take a look at it as requested a month ago.

@cdietrich @szarnekow @ArneDeutsch @kthoms Could please someone review the PR?

[cdietrich]

Fixed in 2.23