Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues #99 and #95 . Linkage error or class not found fixed. #100

Merged
merged 1 commit into from Oct 11, 2014

Conversation

piotrtomiak
Copy link
Contributor

This should fix the LinkageError or at least the ParseException I have reported in Issue #99. Basically, what I found is that jshint.ui was not using json implementation from jshint plugin, but possibly some other version (provided by Tern or NodeJS). Altough this commit should fix the issue for JSHint, installing JSHint it into Eclipse still may brake other plugins, since the shipped json package is modified. The full solution here would be to put modified version of json package into a different package (like e.g. com.eclipsesource.jshint.json). This would help avoid confusion.

@tony-in-nz
Copy link

Please get this into a build a.s.a.p.

The MyEclipse team are adding a LOT of javascript functionality at present and this would be an awesome addition as it stops me adding this tools to the latest bleeding edge version in their CI stream.

This topic refers:
http://www.myeclipseide.com/index.php?name=PNphpBB2&file=viewtopic&p=137571#137571

@paulvi
Copy link
Contributor

paulvi commented Oct 11, 2014

👍

But we need to wait for @ralfstx Ralf

I can release, if Ralf happens to be away for long

@tony-in-nz
Copy link

Big Thx.
:)

@ralfstx
Copy link
Member

ralfstx commented Oct 11, 2014

Will look at it today

@paulvi
Copy link
Contributor

paulvi commented Oct 11, 2014

I was a bit ahead of time, built and bundled as
Enide Studio 2014.17 for Windows x64
http://www.nodeclipse.org/enide/studio/2014/

now waiting for official binary

@tony-in-nz
Copy link

The tool suite looks great.

@ralfstx ralfstx merged commit d301966 into eclipsesource:master Oct 11, 2014
@ralfstx
Copy link
Member

ralfstx commented Oct 11, 2014

Thanks @tonyherstell!
I'll see if I can get the modifications into the minimal-json and then use the original bundle of including a modified copy.

@paulvi
Copy link
Contributor

paulvi commented Oct 13, 2014

@ralfstx Ralf, it was @piotrtomiak Piotr who actually sent PR

@tony-in-nz
Copy link

Quite right.
I can take no credit for the work of Piotr.
I stand on the shoulders of Giants!

@ralfstx
Copy link
Member

ralfstx commented Oct 13, 2014

I'm sorry for mixing that up! Thanks @piotrtomiak!

@tony-in-nz
Copy link

I am sure he wont mind :)
Just VERY VERY happy this is being fixed.
Great support from everyone.

@paulvi
Copy link
Contributor

paulvi commented Oct 13, 2014

:-)

@piotrtomiak
Copy link
Contributor Author

You're welcome guys! OSGi can be very tricky ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants