add Documentation for Date and Time Picker #199
Conversation
There was a problem hiding this comment.
LGTM, only small notes
- The table style can be removed, since it is not a feature table
- The time options are missing
timeFormatandtimeSaveFormat:
https://github.com/eclipsesource/jsonforms/blob/master/packages/material/src/controls/MaterialTimeControl.tsx#L73-L74 - Add a
descriptionto the docs page - A new line is missing at the end
Thanks!
| </TableBody> | ||
| </Table> | ||
| </div> | ||
| ); |
There was a problem hiding this comment.
Add a new line at the end of the file
LukasBoll
force-pushed
the
documentDatePicker
branch
from
bbfc4cc
to
caaf2d4
Compare
|
Thanks for the review, I applied your suggestions and updated the Pull request. |
There was a problem hiding this comment.
Already looks good!
We're mainly missing on how to customize the locale in each picker's modal. Here is the example in our example app: https://github.com/eclipsesource/jsonforms/blob/5da2f0d3afcecc9e2e663ec1238d08ad046dac80/packages/example/src/index.tsx#L44-L47
Please add a separate section where it is explained how to set the global dayjs locale. Ideally with a demo where you can switch between german and english locale like in the example above. Also mention that the dayjs locale customization is React Material only.
Otherwise I went into a lot of detailed comments for the first section. Please apply the feedback also to the remaining sections.
content/docs/date-time-picker.mdx
Outdated
| There are two ways to integrate the Time Picker. It can be embedded via the schema or the UI schema. The Time Picker supports a variety of options, that can be configured in the UI schema. | ||
|
|
||
| ### Schema Based | ||
| An Input Field will be displayed as Time Picker by setting the format of the corresponding field to “time” in the schema. |
There was a problem hiding this comment.
There are some weird quotations marks here
LukasBoll
force-pushed
the
documentDatePicker
branch
3 times, most recently
from
aa7d5ec
to
a913a57
Compare
| <MenuItem value={'en'}>en</MenuItem> | ||
| <MenuItem value={'de'}>de</MenuItem> | ||
| </Select> | ||
| {reloadJsForms===true?<ReloadJsonForms data = {data}reload={()=>{setreloadJsForms(false)}}/>: |
There was a problem hiding this comment.
To change the language, it is not enough to rerender this component or to render JsonForms with different probs, because some components don’t get rerendered/updated. I removed Jsonforms from the DOM just to add it again, this way everything gets updated.
closes eclipsesource#196 Signed-off-by: Lukas Boll <lukas-bool@web.de>
LukasBoll
force-pushed
the
documentDatePicker
branch
from
a913a57
to
b9eabab
Compare
add Documentation for Date and Time Picker
closes #196
Signed-off-by: Lukas Boll lukas-bool@web.de