Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove feature and target projects + add app and folder name #49

Merged
merged 1 commit into from
Dec 27, 2023
Merged

remove feature and target projects + add app and folder name #49

merged 1 commit into from
Dec 27, 2023

Conversation

titou10titou10
Copy link
Contributor

@titou10titou10 titou10titou10 commented Dec 22, 2023

Reduced project structure complexity:

  • removed thecom.eclipsesource.megit.target project: it contained only one useful file

    -> moved thecom.eclipsesource.megit.target.targetfile tocom.eclipsesource.megit.parent/megit.target

  • removed thecom.eclipsesource.megit.product.featureproject: it only included one plugin

    -> thecom.eclipsesource.megit.pluginplugin is now direcly included into the product

  • changed the way the app is packaged:

    • the application is now packaged under theMeGitdirectory, this is easier when unzipping/untaring the app
    • the app name prefix is nowmegit-<unqualified version>

    -> to revert, remove therootFolderandarchiveFileNametags under configuration.products.product in com.eclipsesource.megit.product/pom.xml
    -> this will cause your github actions to not work correctly as the bundles are no more named like"com.eclipsesource.megit-linux.gtk.x86_64.tar.gz"but"megit-0.5.0-linux.gtk.x86_64.tar.gz"

@planger planger self-requested a review December 27, 2023 13:14
Copy link
Collaborator

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, looks good to me! 👍

@planger planger merged commit 3e69949 into eclipsesource:master Dec 27, 2023
1 check passed
planger added a commit that referenced this pull request Dec 27, 2023
planger added a commit that referenced this pull request Dec 27, 2023
planger added a commit that referenced this pull request Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants