Fix for issue #8 and implented things from idea #2 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git as default perspective
Should fix issue eclipsesource#8. Should implement things mentioned in #2.
This was referenced Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I did take a look on issue #8 it seems that when I introduced megit plugin it works as expected. Also with this megit plugin I could implement ideas from #2. It could also help with #3 in future.
BTW implementation of #2 is rather hacking as we don't have real Eclipse RCP application and just customizing workbench. There could be better ways to achieve those things so I wouldn't have to minimize editor area in code after app startup. I lack expertise in following eclipse framework development area :).
Behaviour should be that it starts as expected in #2 and then it keeps its persisted state ( the layout user prefer over times with or without toolbar and editor area ).
@planger could you please test it before merging and comment if there will be something wrong?