Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敡 Use consistent type imports #78

Merged
merged 1 commit into from Feb 24, 2024
Merged

馃敡 Use consistent type imports #78

merged 1 commit into from Feb 24, 2024

Conversation

ralfstx
Copy link
Member

@ralfstx ralfstx commented Feb 24, 2024

The type keyword on imports indicates that the imported type exists only in the typings, but is not available at runtime. Those imports can cause errors if they end up in the JavaScript package.

By consistently using this keyword, those imports can be stripped from the output by esbuild.

The `type` keyword on imports indicates that the imported type exists
only in the typings, but is not available at runtime. Those imports can
cause errors if they end up in the JavaScript package.

By consistently using this keyword, those imports can be stripped from
the output by `esbuild`.
@ralfstx ralfstx merged commit d5c1906 into main Feb 24, 2024
1 check passed
@ralfstx ralfstx deleted the type-imports branch February 24, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant