Mr api #79
Merged
Mr api #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split API definitions into separate modules to separate concerns.
The API documentation used the term "attribute" to refer to the properties of text, blocks, and graphics. However, since these attributes are actually set as JavaScript object _properties_, the term "property" is more appropriate. Furthermore, many of the properties in this library are based on CSS _properties_ such as `line-height` or `font-weight`. SVG only uses the term "attribute" because it inherited it from XML. This commit replaces the term "attribute" with "property" in the API documentation. The types `TextAttrs`, `BlockAttrs`, `InfoAttrs`, and `CustomInfoAttrs` are deprecated in favor of new properties `TextProps`, `BlockProps`, `InfoProps`, and `CustomInfoProps`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.