Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make commands OS agnostic #30

Merged
merged 1 commit into from Jun 9, 2021
Merged

Make commands OS agnostic #30

merged 1 commit into from Jun 9, 2021

Conversation

LukasBoll
Copy link
Collaborator

@LukasBoll LukasBoll commented May 25, 2021

Certain commands were only working on Linux based operation systems.
This commit makes all commands OS agnostic.

Closes #11

@LukasBoll LukasBoll changed the title WIP removed os specific commands closes #11 removed os specific commands Jun 1, 2021
@LukasBoll LukasBoll requested a review from eneufeld June 2, 2021 08:16
@eneufeld
Copy link
Member

eneufeld commented Jun 3, 2021

thank you for the fix, it looks good to me!

@eneufeld
Copy link
Member

eneufeld commented Jun 3, 2021

It would be great if you could update the commit message to better follow the suggestion from here:
https://chris.beams.io/posts/git-commit/
Basically adapt the message subject to be in the imperative mood
add a short description in the message what was broken and what was fixed

@JonasHelming
Copy link
Member

@LukasBoll Could you update the commit message, so we can merge this?

Certain commands were only working on Linux based operation systems.
This commit makes all commands OS agnostic.

Closes #11
@LukasBoll LukasBoll changed the title removed os specific commands Make commands OS agnostic Jun 9, 2021
@LukasBoll
Copy link
Collaborator Author

Thank you for the hint, I just updated the commit message.

Copy link
Member

@eneufeld eneufeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eneufeld eneufeld merged commit 3a2986f into eclipsesource:main Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension is only working for Linux based OS
3 participants