Add new validator ComprobanteTipoCambio #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
driftking301
commented
Oct 27, 2017
driftking301
commented
- Fix attribute TipoCambio must be "1" if Moneda "MXN", put Sello again
- Add exportArray method to retrieve a copy of the attributes
- Add a method to get a new CfdiCreator33 based on a node
- Better fail message on testValidateWithCorrectData
- Add developer helper method procedureCreateSelloAgainOnValidCdfi33
This make easy to read and change the values of an existing Cfdi
Use this procedure to change the cfdi on the file 'asserts/cfdi33-valid.xml' and show io screen the value of the Sello again
bonus: it found a bug in the cfd33-valid.xml file!
|
Very good job. Thanks. Could you please check the revisions I made? |
eclipxe13
requested changes
Oct 27, 2017
|
|
||
| /** | ||
| * Developer: Use this procedure to change the cfdi on the file 'asserts/cfdi33-valid.xml' | ||
| * and show io screen the value of the Sello again |
| * ComprobanteTipoCambio | ||
| * | ||
| * Valida que: | ||
| * - TIPOCAMBIO01: La moneda exista y no tenga un valor vacío. |
There was a problem hiding this comment.
This is very strict could you put the error codes from SAT in description?
| 'TIPOCAMBIO02' => 'Si la moneda es MXN entonces el tipo de cambio debe ser "1" o no debe existir', | ||
| 'TIPOCAMBIO03' => 'Si la moneda es XXX entonces el tipo de cambio no debe existir', | ||
| 'TIPOCAMBIO04' => 'Si la moneda no es MXN ni XXX entonces el tipo de cambio' | ||
| . 'debe seguir el patrón [0-9]{1,18}(.[0-9]{1,6})', |
There was a problem hiding this comment.
Please add space before 'debe'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.