Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance 2022-12-07 #107

Merged
merged 24 commits into from
Dec 7, 2022
Merged

Maintenance 2022-12-07 #107

merged 24 commits into from
Dec 7, 2022

Conversation

eclipxe13
Copy link
Owner

This is a maintenance release fo fix the continuous integration workflow and append pending development changes.

  • Fix test CertificadoTest::testConstructWithValidExample() to allow quoted slashes on name.
  • Add phpdoc to the method Certificate::getCertificateName().
    The value can contain quoted slashes \/ depending on the OpenSSL version.
  • Update script tests/validate.php to validate CFDI 3.3 or CFDI 4.0.
  • Add return types to some methods:
    • Status::comparableValue and Status::__toString.
    • Discoverer::discoverInFile.
  • Improve TestCase::installCertificate(): It doesn't depend on the certificate's file name to install correctly.
  • Update GitHub build workflow:
    • Update GH Workflows: Remove deprecated ::set-output & ::save-state.
    • Split full build actions to individual jobs.
    • Split Windows and Linux testing.

@eclipxe13
Improve TestCase::installCertificate
6606438 
Now, it does not depends on the name of the certificate to perform a correct installation
@eclipxe13
Review Validate first-level objects and improve docblocks & return types
580ba9a
@eclipxe13
Refactor test/validate.php and allow to validate CFDI 3.3 & 4.0
1a3ff0f
@eclipxe13
Add indentation to nowdoc & heredoc
5e5879d
@eclipxe13
Fix test on certificate name
5bfebcc 
This value is different from on different openssl versions.
3.x: uses quoted slashes
1.1.x: does not use quoted slashes
@eclipxe13
Add getCertificateName phpdoc & fix grammar and typos
e4283f0
@eclipxe13
Remove deprecated ::set-output & ::save-state
459a57d
@eclipxe13
Install dependencies running on nektos/act
6711c9a
@eclipxe13
When install libsaxonb-java do not check for matrix
3031503 
Matrix is not used on full-build job
@eclipxe13
Refactor to return exit code 1 on error while wget or unzip
f64c116
@eclipxe13
Simplify extensions
4817bf0
@eclipxe13
Refactor
6a5a34e 
- List actions
- Remove whitespace
@eclipxe13
Install dependencies running on nektos/act on tests job
eec1857
@eclipxe13
Split full build to individual jobs
b5875e7
@eclipxe13
Merge code-coverage and tests jobs
9ba7a12
@eclipxe13
Split tests to tests-windows and tests-windows
3a42161
@eclipxe13
Refactor GH build workflow (split jobs)
9c51c33
@eclipxe13
Version 2.23.4 proposal
9a6f547
@eclipxe13
Fix runs-on for tests-linux & tests-windows
6d80aa8
@eclipxe13
Update version 2.23.4 date
68971d9
@eclipxe13
Add shell: bash to get composer cache directory on windows
3947102
@eclipxe13
Add git fetch depth to allow uploads to scrutinizer
0ec71bd
@eclipxe13
Use actions/cache@v3 instead of v2
a1b0ee4
@eclipxe13
Fix extensions on setup-php according to operating system
f9f4d07 
- linux https://github.com/shivammathur/setup-php/wiki/Php-extensions-loaded-on-ubuntu-22.04
- windows https://github.com/shivammathur/setup-php/wiki/Php-extensions-loaded-on-windows-2022
@eclipxe13 eclipxe13 changed the title Maintenance 2022-12-05 Maintenance 2022-12-07 Dec 7, 2022
@eclipxe13 eclipxe13 merged commit 61c64f1 into master Dec 7, 2022
@eclipxe13 eclipxe13 deleted the development branch May 26, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@eclipxe13