Add locale FR + minor EN improvments #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vadorequest
commented
Feb 24, 2017
| "menu": { | ||
| "shareDatas": "Share Datas", | ||
| "shareDatas": "Share data", |
There was a problem hiding this comment.
FYI data doesn't take any "s" at the end, ever. ;)
| }, | ||
| "share": { | ||
| "text": "Wanna check your GitHub data analysis visually ?", | ||
| "text": "Wanna check your GitHub data analysis visually?", |
There was a problem hiding this comment.
FYI In english, punctuation is always close to the "left word".
| @@ -0,0 +1,61 @@ | |||
| { | |||
| "language": { | |||
There was a problem hiding this comment.
I'm not sure what this language key is for, it seems it is mixed up in the zh-CN and en-US files
There was a problem hiding this comment.
If used for user to change languages, but not work now because we use more than tow languages. I'll change this after merged.
Open
|
Great work!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.