General mostly performance-neutral improvements #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhatfield
force-pushed
the
samhatfield/general_improvements
branch
4 times, most recently
from
5527530
to
0044721
Compare
|
I think we might as well get this merged before it grows too big. |
wdeconinck
approved these changes
Jun 10, 2024
Also remove unnecessary duplicate of JGL.
Apparently this is unnecessary, so we remove it, and all ranks will go from north-south.
The parent scope (BUTTERFLY_ALG_MOD) has this already.
Also remove that copy to ZVECIN -> it served no purpose.
In both cases we have a temporary variable copy the same type and shape as what's being copied into it. These can be deleted.
The previous combination of IF statements meant an unnecessary number of different calls to GEMM. GEMM now wraps the double and single precision versions so we can take advantage of this to reduce the amount of code repetition.
samhatfield
force-pushed
the
samhatfield/general_improvements
branch
from
36a6734
to
2a2581a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will collect suggested changes that came as a result of the deep-dive into ecTrans with Nvidia colleagues.