Enable MeshBuilder to set up the Grid #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdeconinck
requested changes
Jul 27, 2023
src/atlas/mesh/MeshBuilder.cc
Outdated
Comment on lines
111
to
113
| } else { | ||
| throw_Exception("In MeshBuilder: can't validate a grid of type " + grid.type() + " from config"); | ||
| } |
There was a problem hiding this comment.
We can in principle use the iterator here with random access as last resort. It will work for any grid, but could be slower than the 2 above methods.
auto point = *(grid.lonlat().begin()+global_indices[i]-1);There was a problem hiding this comment.
Good suggestion, I've added this
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #152 +/- ##
===========================================
+ Coverage 78.01% 78.04% +0.03%
===========================================
Files 817 817
Lines 52464 52588 +124
===========================================
+ Hits 40928 41043 +115
- Misses 11536 11545 +9
☔ View full report in Codecov by Sentry. |
Co-authored-by: Willem Deconinck <wdeconinck@me.com>
Co-authored-by: Willem Deconinck <wdeconinck@me.com>
Co-authored-by: Willem Deconinck <wdeconinck@me.com>
Co-authored-by: Willem Deconinck <wdeconinck@me.com>
Co-authored-by: Willem Deconinck <wdeconinck@me.com>
Co-authored-by: Willem Deconinck <wdeconinck@me.com>
|
@wdeconinck — Thanks for the feedback, and mostly for the extensive planning discussion in the preceding issue! |
wdeconinck
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a config argument to the MeshBuilder's call operator. This config can be used to request setting the mesh's grid, either as an UnstructuredGrid from the available coordinates in the MeshBuilder, or as a grid of choice according to the config.
This resolves #150 for the most part. Some edge cases are discussed there that I did not code up in this PR (could be added later if needed, though).