Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atlas_io is an adaptor library when eckit_codec is available #181

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

wdeconinck
Copy link
Member

When eckit is compiled with feature ECKIT_CODEC enabled, then atlas_io will with this PR now delegate all calls to eckit_codec.

This ensures a smooth transition for downstream projects of atlas_io (such as atlas-orca, multio) to migrate to use eckit_codec directly.

This PR supersedes PR #180

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.07%. Comparing base (5dc85c9) to head (d244194).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #181   +/-   ##
========================================
  Coverage    80.07%   80.07%           
========================================
  Files          859      859           
  Lines        63682    63682           
========================================
  Hits         50993    50993           
  Misses       12689    12689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wdeconinck wdeconinck merged commit 7abbf1a into develop Mar 25, 2024
112 checks passed
wdeconinck added a commit that referenced this pull request Apr 9, 2024
* release/0.37.0: (23 commits)
  Update Changelog
  Version 0.37.0
  Projection base implementation derivatives performance/encapsulation … (#185)
  atlas_io is an adaptor library when eckit_codec is available (#181)
  Fix build for configuration setting ATLAS_BITS_LOCAL=64 (#184)
  Revert "Avoid linker warnings on macOS about 'ld: warning: could not create compact unwind for ...'"
  Cosmetic: readability braces
  Initialize std::array values to zero because valgrind complains, even though c++ standard mandates it should be default-initialized to zero
  Fix bug in TraceT caused by typo where the title was wrong
  Avoid linker warnings on macOS about 'ld: warning: could not create compact unwind for ...'
  Use new LocalConfiguration baseclass functions in util::Config and util::Metadata instead of eckit::Value backdoor
  Removed leftover code missed in PR #175
  Update `SphericalVector` to work with StructuredColumns as source functionspace. (#175)
  Bugfix for regional grids with ny > nx
  Refactoring of interpolation::method::SphericalVector and implementation of adjoint methods. (#168)
  Added test with empty integer sequence.
  Added arrayForEachDim method.
  Add docs build workflow
  Github Actions: Fix macOS MPI slots
  Fix for elements that might have unassigned partition via parallel Delaunay meshgenerator
  ...
@wdeconinck wdeconinck deleted the feature/eckit_codec branch April 9, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants