Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/read indexing time #146

Merged
merged 5 commits into from Jun 15, 2020
Merged

Feature/read indexing time #146

merged 5 commits into from Jun 15, 2020

Conversation

aurghs
Copy link
Contributor

@aurghs aurghs commented Jun 12, 2020

Add indexing_time in time_dims possible values. Add some test.

@coveralls
Copy link

coveralls commented Jun 12, 2020 •
edited

Pull Request Test Coverage Report for Build 364

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.04%) to 95.365%
Totals Coverage Status
Change from base Build 353: 1.04%
Covered Lines: 1235
Relevant Lines: 1278
💛 - Coveralls

alexamici
alexamici suggested changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@alexamici alexamici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review inline comments.

cfgrib/dataset.py Outdated Show resolved Hide resolved
tests/test_30_dataset.py Show resolved Hide resolved
@alexamici alexamici self-requested a review June 15, 2020 09:30
@alexamici alexamici closed this Jun 15, 2020
@alexamici alexamici reopened this Jun 15, 2020
@alexamici alexamici merged commit c062f5d into stable/0.9.8.x Jun 15, 2020
@alexamici alexamici deleted the feature/read-indexing_time branch November 20, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexamici alexamici alexamici approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aurghs @coveralls @alexamici