Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contribution guide refers to removed files #90

Open
ejd opened this issue Jun 21, 2024 · 3 comments
Open

contribution guide refers to removed files #90

ejd opened this issue Jun 21, 2024 · 3 comments

Comments

@ejd
Copy link

ejd commented Jun 21, 2024

What maintenance does this project need?

The Get Started! section of CONTRIBUTING.rst refers to ci/requirements-tests.txt but the entire contents of the ci directory was removed back in 2021 by a6cff6a. Was the removal a mistake? Or is the contribution guide out of sync with the project's current practices?

Organisation

Self

@shahramn
Copy link
Collaborator

Thanks for spotting this. I will restore those 2 files

@ejd
Copy link
Author

ejd commented Jun 25, 2024

@shahramn Hi, thank you for addressing this. I'm sorry I didn't mention this in the original issue, but I think the real fix is to revert the entirety of a6cff6a; to restore all of the files removed by that commit.

The ci/requirements-*.txt files are built from the ci/requirements-*.in files by pip-compile via make update-req. Without the *.in files, you can't generate new *.txt files with up-to-date versions of the dependencies.

@shahramn shahramn reopened this Jun 25, 2024
@shahramn
Copy link
Collaborator

Apologies. I will restore the files. In the future we will switch to using toml

shahramn added a commit that referenced this issue Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants