call the builder.py script from the setup script #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the travis build fails because eccodes is not installed in that environment. |
|
|
|
This PR breaks the Travis CI build. So cannot be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will automatically build the fast cffi based bindings.
An additional advantage is that the python module gets installed below /usr/lib64/python3.x/site-packages/ now and no longer below /usr/lib/python3.x/site-packages/
When manually calling the builder.py script after having done a "setup.py build", and then adding it to the build directory, and calling "setup.py install", the module ends up below /usr/lib.
This is especially important when packaging the module for a linux distribution (as I am trying to do now for Fedora), since there are strict guidelines where binary python packages need to be installed.
In case you do not wish to have a call to this builder.py script in a default install, please consider adding it as an option to the setup.py script, so it can be enabled if needed.