Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit testing with GitHub actions (linux, macos and windows) #42

Merged
merged 8 commits into from Dec 15, 2020

Conversation

alexamici
Copy link
Contributor

@alexamici alexamici commented Nov 17, 2020

After Travis-CI has changed its terms of service several Open Source projects are moving to GitHub Actions.

This PR adds tests with GitHub actions and remove Travis-CI.

Note that the code-style workflows fails due to a few trivial black failures. They can be fixed in a different PR. (fixed by installing the version of black in conda-forge, not defaults)

Windows write unit tests fail mostly due to a problem with the template folder.

@codecov-io
Copy link

codecov-io commented Nov 17, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@db8bfd7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #42   +/-   ##
==========================================
  Coverage           ?   77.11%           
==========================================
  Files              ?       20           
  Lines              ?     2229           
  Branches           ?      200           
==========================================
  Hits               ?     1719           
  Misses             ?      453           
  Partials           ?       57           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db8bfd7...38bf64e. Read the comment docs.

@shahramn
Copy link
Collaborator

Dear Alessandro,
I would like to keep the Travis stuff for now. Can you re-submit your PR without the travis yaml deletion please?

Copy link
Collaborator

@shahramn shahramn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Alessandro,
I would like to keep the Travis stuff for now. Can you re-submit your PR without the travis yaml deletion please

@alexamici
Copy link
Contributor Author

@shahramn apparently I don't have write permission to the repo anymore, so I can't update the files in branch and thus the PR.

This appears to be a recent change as I did create the branch and the PR by pushing to the eccodes-python repo.

I can fork and create another PR later in the week.

@shahramn shahramn changed the base branch from develop to PR42_GitHub_actions December 15, 2020 13:13
@shahramn shahramn merged commit 073eced into PR42_GitHub_actions Dec 15, 2020
@shahramn
Copy link
Collaborator

I have merged this to a separate branch which will later be merged to develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants