Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add automated health checks #733

Merged
merged 7 commits into from
May 5, 2023

Conversation

dylanschultzie
Copy link
Contributor

There are really 3 parts to this PR:

  1. I ran an auto-formatter, so it copied the formatting against the rest of the repo
  2. Fixed self-hosted healthchecks, as the normal healthchecks.io uses a different ping path system
  3. Added functionality for auto-created healthchecks. This only kicks in if the apiKey property is added, and is created based off of the name property (which defaults to networkName)

Signed-off-by: Dylan Schultz <hello@schultzie.dev>
Signed-off-by: Dylan Schultz <hello@schultzie.dev>
Signed-off-by: Dylan Schultz <hello@schultzie.dev>
Signed-off-by: Dylan Schultz <hello@schultzie.dev>
@tombeynon
Copy link
Contributor

This is excellent, thanks so much @dylanschultzie!

The only part I'm considering changing is whether we should make that timeout param dynamic when creating the check. I assume that's setup to make a daily check right now?

I'll give this a bit of a test ASAP

@dylanschultzie
Copy link
Contributor Author

@tombeynon the timeout param is set to every 24 hours, and grace period to 12. I tried to find a reasonable medium so as to not dilute the networks.local.json file, BUT I'm more than happy to add in extra params if you'd prefer.

@dylanschultzie
Copy link
Contributor Author

Excuse me, it's the other way around - the grace period is 24 hours, and timeout is 12 hours.

Signed-off-by: Dylan Schultz <hello@schultzie.dev>
Signed-off-by: Dylan Schultz <hello@schultzie.dev>
@gh0stdotexe
Copy link
Contributor

This is awesome - can't wait to give it a go!

@tombeynon
Copy link
Contributor

All working great, thanks so much for this and the extra config additions @dylanschultzie 🚀

@tombeynon tombeynon merged commit d795db9 into eco-stake:master May 5, 2023
@dylanschultzie dylanschultzie deleted the schultzie/healthchecks branch May 5, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants