Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract TestSuite and empty files crashes xunit #328

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

filiptypjeu
Copy link
Contributor

Added tests exposing a bugs where files with no default export and files with an abstract TestSuite crashes xunit. Fixed the bugs in the code by adding more checks to the test suite loader.

…les with an abstract TestSuite crashes xunit. Fixed the bugs in the code by adding more checks to the test suite loader.
Copy link
Member

@SteveDesmond-ca SteveDesmond-ca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Thanks for these fixes! I'll do some quick cleanup and get v1.2 released this afternoon.

@SteveDesmond-ca SteveDesmond-ca merged commit 7f34ef1 into ecoAPM:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants