slaves/dns: 集成测试添加 #156
Closed
slaves/dns: 集成测试添加 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flycash
requested changes
Feb 26, 2023
internal/integration/base_test.go
Outdated
| slaves := make([]*sql.DB, 0, len(s.slavedsns)) | ||
| for _, slavedsn := range s.slavedsns { | ||
| slave, err := sql.Open(s.driver, slavedsn) | ||
| if s.geterName == "roundrobin" { |
There was a problem hiding this comment.
这里最好是初始化这个 MasterSlaveSuite 的地方直接指定好 Slaves 的实现，而不是这么分发
| @@ -87,6 +87,7 @@ func TestMasterSlaveDelete(t *testing.T) { | |||
| driver: "mysql", | |||
| masterdsn: "root:root@tcp(localhost:13307)/integration_test", | |||
| slavedsns: []string{"root:root@tcp(localhost:13308)/integration_test"}, | |||
| geterName: "roundrobin", | |||
There was a problem hiding this comment.
就是你这里直接传入 Slaves 实例，而不是这样一个 getter name
internal/slaves/dns/dns.go
Outdated
| ctx, cancel := context.WithTimeout(context.Background(), s.timeout) | ||
| err := s.getSlaves(ctx) | ||
| cancel() | ||
| // 尽最大努力重试，拿到dns的响应 | ||
| if err != nil { | ||
| continue |
There was a problem hiding this comment.
在 continue 之前打印一下这个 err 吧，你可以考虑引入一个 log func(msg, args...) 啥的字段，也可以考虑直接用 log.Println。大体上我认为需要告诉一下用户，但是怎么告诉用户就不是特别重要了。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.