Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement methods for sp types #2

Closed
noamross opened this issue Mar 20, 2017 · 1 comment
Closed

Implement methods for sp types #2

noamross opened this issue Mar 20, 2017 · 1 comment

Comments

@noamross
Copy link
Collaborator

This should be pretty simple, just convert sp to sf. Need to set up S3 dispatch for this.

@noamross noamross added this to the Package Release milestone Mar 20, 2017
@mpadge
Copy link
Member

mpadge commented Mar 21, 2017

@noamross seems like a good place to cross-fertilise your grand work on fasterize with osmdata - submitted to ropensci. You're going from sf to other formats; osmdata does conversions in the other directions, absent direct Depends or Imports of the beast that is sf.

Full sp code is also included here - feel free to crib all you like, but note that Rcpp dis-mantling of S4 objects is considerably slower than simple S3 ones, so your results aren't likely to be as impressive as for sf. osmdata has some timing comparisons here, which don't even include sp because it's orders of magnitude slower.

@noamross noamross removed this from the Package Release milestone Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants