Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tested with Django 2.2 LTS #59

Merged
merged 1 commit into from
May 2, 2019
Merged

Conversation

brunoprograma
Copy link

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.008% when pulling c18c61c on ribeiroti:master into ced3d20 on ecometrica:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.008% when pulling c18c61c on ribeiroti:master into ced3d20 on ecometrica:master.

@jordiecometrica
Copy link

If I'm reading this right, we're not currently running the tests on 3.6 at all, so coverage didn't run on Django 2.2 either?

https://coveralls.io/builds/23153266

@brunoprograma
Copy link
Author

If I'm reading this right, we're not currently running the tests on 3.6 at all, so coverage didn't run on Django 2.2 either?

https://coveralls.io/builds/23153266

Well.. I don't know... I'm just using it on py 3.6 and django 2.2 and works. Django 2.1 and 2.2 are pretty similar, but 2.2 is a long term support version.

@jordiecometrica
Copy link

It appears the tests actually failed on Python 3.6:

https://travis-ci.org/ecometrica/django-multisite/jobs/527392239

@brunoprograma
Copy link
Author

Yes, maybe I don't get the error in my env because I'm not using sqlite

packages/django/db/backends/sqlite3/base.py", line 66, in <module> check_sqlite_version() File "/home/travis/build/ecometrica/django-multisite/.tox/py36-django2.2/lib/python3.6/site-packages/django/db/backends/sqlite3/base.py", line 63, in check_sqlite_version raise ImproperlyConfigured('SQLite 3.8.3 or later is required (found %s).' % Database.sqlite_version) django.core.exceptions.ImproperlyConfigured: SQLite 3.8.3 or later is required (found 3.8.2).

@jordiecometrica
Copy link

Looks like it's just coverage. Further below the tests actually pass.

Good enough for me.

@jordiecometrica jordiecometrica merged commit c18c61c into ecometrica:master May 2, 2019
@jordiecometrica
Copy link

Thanks for the changes.

@brunoprograma
Copy link
Author

No. I thank you. I'm just enjoying the package. Regards!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants