Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format #19

Merged
merged 36 commits into from
Feb 9, 2015
Merged

Format #19

merged 36 commits into from
Feb 9, 2015

Conversation

nighca
Copy link
Member

@nighca nighca commented Feb 6, 2015

DOM写操作以及规则对应的format

@coveralls
Copy link

Coverage Status

Coverage decreased (-7.22%) to 91.83% when pulling 8f23601 on nighca:format into e7613a4 on ecomfe:master.

@nighca
Copy link
Member Author

nighca commented Feb 6, 2015

测试覆盖率降了好多,慢慢补...

try {
rule.lint(cfg[rule.name], document, reporter);
}
catch (e) {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的错误看下有没必要加到 reporter 里

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

js运行错误可能是rule实现的问题,reporter的结果都应该是html代码的规范问题,不应该加进来吧。如果这个错误信息有意义的话,我找另外一个地方放吧

@coveralls
Copy link

Coverage Status

Coverage decreased (-7.22%) to 91.83% when pulling f451540 on nighca:format into e7613a4 on ecomfe:master.

chriswong added a commit that referenced this pull request Feb 9, 2015
@chriswong chriswong merged commit 7059e08 into ecomfe:master Feb 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants