feat: add useToggleOrSet for convenience #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not just add a |
|
We can add force parameter to both useBoolean and useToggle |
|
maybe the useToggle and useSwitch can be replaced by useToggle + |
|
I prefer this: const [value, {toggle}] = useBoolean();
toggle(true /false);
const [value, on, off, toggle] = uswSwitch();
toggle(true / false);
const [value, toggle] = useToggle();
toggle(true / false); |
|
@otakustay all right, i gonna fix it. #98 |
otakustay
requested changes
Aug 9, 2021
packages/boolean/src/index.ts
Outdated
| @@ -7,8 +7,8 @@ const reducers = { | |||
| off() { | |||
| return false; | |||
| }, | |||
| toggle(value: boolean) { | |||
| return !value; | |||
| toggle(prevState: boolean, arg: any) { | |||
There was a problem hiding this comment.
arg should be boolean, strong typed hooks are always better
There was a problem hiding this comment.
The type will be incorrect when i use the function as a event handler or some other callback，e.g.
<div on-click = { useToglle }></on-click>
<custom-comp on-selected= { useToggle }></custom-comp>
There was a problem hiding this comment.
I decide to accept this kind of "hacking", but please change its type to unknown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.