Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

是不是源码没有全部开源? #8

Closed
keenwon opened this issue Jan 17, 2017 · 3 comments
Closed

是不是源码没有全部开源? #8

keenwon opened this issue Jan 17, 2017 · 3 comments

Comments

@keenwon
Copy link

keenwon commented Jan 17, 2017

https://github.com/ecomfe/san/blob/91dc49af96fba09644c27508f676d9bd21e2753c/src/main.js#L3336

/* eslint-disable operator-linebreak */
/**
 * 清空从已有的el进行初始化的行为
 *
 * @param {Object} options 初始化参数
 */
Component.prototype._initFromEl =
/* eslint-enable operator-linebreak */

另外,全部逻辑都在一个4k+的单文件?

@otakustay
Copy link
Collaborator

代码已经全部在这里了,就是这一个文件,你看到的这个代码其实是把2个Component.prototype上的方法同时指向一个空函数,是 @errorrik 同学做手工体积优化的一个常见手段

@leeight
Copy link
Contributor

leeight commented Jan 17, 2017

另外,全部逻辑都在一个4k+的单文件?

erik 一贯的风格,40k+对他也没啥问题

@keenwon
Copy link
Author

keenwon commented Jan 17, 2017

好吧,看蒙了,其实就是个连等换了行。

@keenwon keenwon closed this as completed Jan 17, 2017
wangshuonpu pushed a commit to wangshuonpu/san that referenced this issue Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants