根据cr评论修改handleTableCommand的实现 #264
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -323,7 +322,19 @@ define( | |||
| * @protected | |||
| */ | |||
| exports.handleTableCommand = function (triggerType, name, args) { | |||
| var handled = this.handleStatusCommand(triggerType, name, args); | |||
| var handled = false; | |||
There was a problem hiding this comment.
这个函数的handled return 看起来并没有用途
There was a problem hiding this comment.
bool类型返回值有这样一个作用：假如现有的处理过程不能满足需求，有扩展handleTableCommand的需求，扩展时一般会调用父类的方法，这个时候，返回值可以提供“是否处理过”作为参考。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.