Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VChat option type are broken #751

Closed
1 task done
kaine0923 opened this issue Dec 7, 2023 · 5 comments
Closed
1 task done

VChat option type are broken #751

kaine0923 opened this issue Dec 7, 2023 · 5 comments

Comments

@kaine0923
Copy link

请确认

  • 我可以确认这个问题无法在 ECharts 项目本身中复现。

您是如何将 Vue-ECharts 引入项目的?

通过 ES 模块 import

版本信息

+-- vue-echarts@6.6.2 
| +-- echarts@5.4.3 
| +-- vue-demi@0.13.11
| `-- vue@3.3.10

问题详情

image

export type Option = EChartsOption;

https://github.com/apache/echarts/blob/master/src/export/core.ts#L96-L113

[key in GetMainType<OptionUnion>]?: Arrayable<ExtractComponentOption<OptionUnion, key>>

The purpose of this code is to retrieve the option type for a specific component in EChartsOption. However, due to the type inference, the code produces the following inference result

[x: string]: unknown
[x: number]: unknown

问题复现

https://github.com/kaine0923/vue-echarts-type-issue

@liyuan1125
Copy link

+1

@radusuciu
Copy link

Can confirm this issue happens with versions > 6.6.1. Option typing and inference worked fine for me before but is now broken.

@DMOAbove
Copy link

Same here, after 6.6.1 as previously said.

image

kingyue737 added a commit to kingyue737/vitify-nuxt that referenced this issue Dec 15, 2023
@demiro
Copy link

demiro commented Dec 15, 2023

I have the same issue... and can confirm that downgrading it to 6.6.1 works

Justineo added a commit that referenced this issue Dec 18, 2023
@Justineo
Copy link
Member

Seems to be introduced by e224c49.

I've reverted the changes and it should be now fixed in v6.6.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants