Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

关于Group类中delChildrenFromStorage方法的一点疑问 #92

Closed
shejiJiang opened this issue Sep 10, 2014 · 1 comment
Closed

关于Group类中delChildrenFromStorage方法的一点疑问 #92

shejiJiang opened this issue Sep 10, 2014 · 1 comment

Comments

@shejiJiang
Copy link

Group.prototype.delChildrenFromStorage = function(storage) {
for (var i = 0; i < this._children.length; i++) {
var child = this._children[i];
storage.delFromMap(child);
if (child.type === 'group') {
child.delChildrenFromStorage(storage);
}
}
};
这边的storage.delFromMap(child);是否应该改成storage.delFromMap(child.id);
因为delFromMap方法中的第一句 var el = this._elements[elId];有个索引查找。

@pissang
Copy link
Contributor

pissang commented Sep 10, 2014

是的,非常感谢指出这个bug

pissang added a commit that referenced this issue Sep 10, 2014
@pissang pissang closed this as completed Sep 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants