feat(sector): enhance sector corner radius to support configuring any one corner. #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
pissang
reviewed
Dec 29, 2021
pissang
reviewed
Dec 29, 2021
…he sector is annular. 2) skip normalize if no corner radius.
pissang
reviewed
Jan 4, 2022
pissang
reviewed
Jan 4, 2022
pissang
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corner radius for the sector has been supported since v5, but it was limited to a pair of corners, either an inner pair or an outer pair. I can remember @Ovilia asked about it at that time.
This PR enhances this feature so that we can configure the radius of four corners at will. As shown below, the sector has four different corner radius.
A related test case is
sector.html.Moreover, in commit 53819e9, I tweaked the watch script to process lib extension immediately after the source was compiled.