New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: coarse pointer tolerance #918
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Ovilia
force-pushed
the
feat-coarse-pointer
branch
from
July 7, 2022 09:22
f2ebf11
to
1cc7bbc
Compare
plainheart
reviewed
Jul 7, 2022
pissang
reviewed
Aug 12, 2022
pissang
reviewed
Aug 12, 2022
The whole design looks good. There are several optimizations we can do to improve the code. I commented about them. |
plainheart
reviewed
Aug 16, 2022
I have no more questions on this PR |
plainheart
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
This PR is intended to increase elements' responsive area on mobile devices so that elements can be touched more easily.
The idea is inspired by W3C's Understanding Success Criterion 2.5.5: Target Size.
Algorithm
The algorithm can be briefly described as:
For cases that have too many elements, this feature can be turned off by setting
ignoreCoarsePointer
to the elements.Tested with the Apache ECharts test cases and in most cases the extra calculation time is under 0.1ms.
API
useCoarsePointer
('auto'
|true
|false
): whether to enable thie feature. If set to be'auto'
, it's turned on only for mobile devices.pointerSize
(number
): pointer position is increased by this size in diameter.Each element can be set with
ignoreCoarsePointer
to turn off this feature individually: