Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed notebooks and YAML files; added a pyproject.toml for compatibility with poetry #22

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

NormannR
Copy link
Contributor

No description provided.

@albop
Copy link
Collaborator

albop commented Dec 21, 2020

The pyproject.toml is a nice touch. It is a way to require the right version from dolo and dolark. But in this instance, it complicates stuff a little bit, because we have jupyter notebooks. The kernels need to have the right versions of the library, and I"m not sure how we can ensure that.

@NormannR
Copy link
Contributor Author

It is possible to run ipykernel within the poetry environment and the dependencies are properly shared. In VSCode, for example, choosing the poetry environment interpreter works well on my computer.

@albop
Copy link
Collaborator

albop commented Dec 21, 2020 via email

@NormannR
Copy link
Contributor Author

I thought too, but it ended up working without manipulation. Otherwise, adding the environment to the kernelspec through a python -m ipykernel install --user --name=myenv or modifying the kernel.json file should do the trick.

I only modified the notebooks. If they are validated, I shall export them to the .py format before the PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants