Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bayer & Luetticke REMARK #47

Open
sbenthall opened this issue Mar 18, 2020 · 7 comments
Open

Bayer & Luetticke REMARK #47

sbenthall opened this issue Mar 18, 2020 · 7 comments
Assignees

Comments

@sbenthall
Copy link
Contributor

Dual of econ-ark/HARK#361

@project-bot project-bot bot added this to Needs Triage in Issues & PRs Mar 18, 2020
@sbenthall
Copy link
Contributor Author

also econ-ark/HARK#531

@sbenthall sbenthall self-assigned this Apr 2, 2020
@sbenthall
Copy link
Contributor Author

For @sbenthall to do:

reorganizing of material ... Maybe merge OneAsset and TwoAsset (or maybe not, but we should make it clear to people that the one they want to look at is the one with extensive documentation -- everybody's natural inclination is to think you should start with OneAsset, figure that out, and then move to TwoAsset. Perhaps the files could be renamed --

After that, hand off to @MridulS for containerization.

@llorracc
Copy link
Collaborator

Bayer-Luetticke should be entirely in REMARKs. As it stands, part of it is in HARK/examples, but it actually uses very little HARK code -- it's basically a straight replication of their model.

@sbenthall
Copy link
Contributor Author

this looks complete

Issues & PRs automation moved this from Needs Triage to Done Mar 5, 2021
@llorracc
Copy link
Collaborator

llorracc commented Mar 6, 2021

@MridulS @DrDrij

@llorracc llorracc reopened this Mar 6, 2021
Issues & PRs automation moved this from Done to In progress Mar 6, 2021
@llorracc
Copy link
Collaborator

llorracc commented Mar 6, 2021

@sbenthall @MridulS @DrDrij

Reopening just because for some reason BayerLuetticke does not show up on econ-ark.org, though I see that there is a BayerLuetticke.md metadata file in the econ-ark.org repo.

@MridulS or @DrDrij, I thought that we now had a system where things in that directory were automatically incorporated in the econ-ark.org launcher?

@DrDrij
Copy link
Member

DrDrij commented Mar 13, 2021

Hi @llorracc. As you have noticed, the BayerLuetticke markdown file is present and therefore should be showing up on econ-ark.org.

image

I have spent a little time troubleshooting and it appears there is a parsing issue within the original file.

The issue was double quotations eg:

abstract: "Code that solves models from the paper of Bayer and Luetikke, "Solving heterogeneous agent models in discrete time with many idiosyncratic states by perturbation methods"." # abstract: optional

I have adjusted abstract and message by escaping the nested quotation marks:

abstract: "Code that solves models from the paper of Bayer and Luetikke, \"Solving heterogeneous agent models in discrete time with many idiosyncratic states by perturbation methods\"." # abstract: optional

After doing so BayerLuetticke now is correctly displayed on our website.

image

Note: the the title appearing on the website is taken from the title field. If you add to the first line an entry name: BayerLuetticke the display name for the material will match this value. The code behind tries to extract a name for the material in this order:

{% if material.name %} {{ material.name }} {% elsif material.title %} {{ material.title }} {% elsif material.remark-name %} {{ material.remark-name }} {% elsif material.title-original-paper %} {{ material.title-original-paper }} {% else %} {{ github_repo }} {% endif %}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Issues & PRs
  
In progress
Development

No branches or pull requests

3 participants