Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors while running DemARK notebooks [master branch, py3.7] #62

Open
MridulS opened this issue Sep 4, 2019 · 4 comments
Open

Errors while running DemARK notebooks [master branch, py3.7] #62

MridulS opened this issue Sep 4, 2019 · 4 comments
Assignees

Comments

@MridulS
Copy link
Member

MridulS commented Sep 4, 2019

The following notebooks gives errors (and why) using current master branch.

  • Alternative Combinations of Parameter Values - this one has an exercise/interactive notebook as users need to create consumer problems first then run the second cell.

  • A Gentle Introduction to HARK - this one also has a small exercise.

  • IncExpectationExample_Roszypal-Schlafmann - data not available in the repo, tries to read f = open('/Volumes/Data/Job/Discuss/2018-07_NBER_Behavioral-Macro/cstwMPC/Code/Python/Results/LCbetaPointNetWorthLorenzFig.txt','r') [should be changed]

  • Structural-Estimates-From-Empirical-MPCs-Fagereng-et-al- T_kill referenced before assignment. [Fixed]

@project-bot project-bot bot added this to Needs Triage in Issues & PRs Sep 4, 2019
@llorracc llorracc self-assigned this Sep 13, 2019
@llorracc
Copy link
Collaborator

llorracc commented Nov 3, 2019

@MridulS is this fixed?

@MridulS
Copy link
Member Author

MridulS commented Nov 4, 2019

IncExpectationExample_Roszypal-Schlafmann contains a datafile which it tries to read but its not present in this repository , should I create a data folder in demark?

@llorracc
Copy link
Collaborator

llorracc commented Nov 4, 2019

I think we have thought we had fixed this like 4 times. @shaunagm may remember. In any case, the lesson seems to be that it is a mistake to try to write a notebook that uses an external file. Full stop.

In a conv with @sbenthall earlier today, I said that DemARKs are supposed to be basically self-contained Jupyter notebooks, and that if you need a collection of related/support/input files then we should call what you are doing a "REMARK." This would fall under the "Explorations" letter of the REMARK acronym.

So, the solution is NOT to add files or subdirectories to the DemARK. I feel strongly that DemARK notebooks should be self-contained and standalone. Instead, @MridulS, could you make a PR to make it a REMARK? I think this would mainly involve making the *.md and *.bib files described in the (updated today) REMARK README.md. (This is very easy).

@llorracc
Copy link
Collaborator

llorracc commented Nov 7, 2019

@MridulS why don't you try your solution of embedding the data in the notebook. Please do a really good job of describing somehow what you have done and how you did it, and where the data came from, so that we might be able easily to point students to this as an example; you can put this explanatory material in IncExpectationExample_Roszypal-Schlafmann-README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Issues & PRs
  
Needs Triage
Development

No branches or pull requests

2 participants