You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The following notebooks gives errors (and why) using current master branch.
Alternative Combinations of Parameter Values - this one has an exercise/interactive notebook as users need to create consumer problems first then run the second cell.
A Gentle Introduction to HARK - this one also has a small exercise.
IncExpectationExample_Roszypal-Schlafmann - data not available in the repo, tries to read f = open('/Volumes/Data/Job/Discuss/2018-07_NBER_Behavioral-Macro/cstwMPC/Code/Python/Results/LCbetaPointNetWorthLorenzFig.txt','r') [should be changed]
Structural-Estimates-From-Empirical-MPCs-Fagereng-et-al- T_kill referenced before assignment. [Fixed]
The text was updated successfully, but these errors were encountered:
IncExpectationExample_Roszypal-Schlafmann contains a datafile which it tries to read but its not present in this repository , should I create a data folder in demark?
I think we have thought we had fixed this like 4 times. @shaunagm may remember. In any case, the lesson seems to be that it is a mistake to try to write a notebook that uses an external file. Full stop.
In a conv with @sbenthall earlier today, I said that DemARKs are supposed to be basically self-contained Jupyter notebooks, and that if you need a collection of related/support/input files then we should call what you are doing a "REMARK." This would fall under the "Explorations" letter of the REMARK acronym.
So, the solution is NOT to add files or subdirectories to the DemARK. I feel strongly that DemARK notebooks should be self-contained and standalone. Instead, @MridulS, could you make a PR to make it a REMARK? I think this would mainly involve making the *.md and *.bib files described in the (updated today) REMARK README.md. (This is very easy).
@MridulS why don't you try your solution of embedding the data in the notebook. Please do a really good job of describing somehow what you have done and how you did it, and where the data came from, so that we might be able easily to point students to this as an example; you can put this explanatory material in IncExpectationExample_Roszypal-Schlafmann-README.md
The following notebooks gives errors (and why) using current master branch.
Alternative Combinations of Parameter Values
- this one has an exercise/interactive notebook as users need to create consumer problems first then run the second cell.A Gentle Introduction to HARK
- this one also has a small exercise.IncExpectationExample_Roszypal-Schlafmann
- data not available in the repo, tries to readf = open('/Volumes/Data/Job/Discuss/2018-07_NBER_Behavioral-Macro/cstwMPC/Code/Python/Results/LCbetaPointNetWorthLorenzFig.txt','r') [should be changed]
Structural-Estimates-From-Empirical-MPCs-Fagereng-et-al
-T_kill
referenced before assignment. [Fixed]The text was updated successfully, but these errors were encountered: