Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small: NullFunc #42

Closed
mnwhite opened this issue Jun 2, 2016 · 1 comment
Closed

Small: NullFunc #42

mnwhite opened this issue Jun 2, 2016 · 1 comment

Comments

@mnwhite
Copy link
Contributor

mnwhite commented Jun 2, 2016

We currently have NullFunc as a function that returns an array of nans (for use as a placeholder/default function), but this should be expanded slightly. NullFunc should be a class whose constructor takes no inputs; it has convergence_criteria=[], so that any instance of NullFunc has a distance of 0 from another instance. Anywhere else in the code where we refer to NullFunc should be replaced with NullFunc(). The new class' call method should be rewritten more robustly; as is, it fails when the input is a scalar.
@mnwhite
Copy link
Contributor Author

mnwhite commented Jun 18, 2016

Fixed in latest commit to comments-and-cleanup.

@mnwhite mnwhite closed this as completed Jun 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mnwhite