[ECO-379] Check order price field against lookup key #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alnoki
changed the base branch from
main
to
eco-378-remove-unnecessary-mutable-borrows
Base automatically changed from
eco-378-remove-unnecessary-mutable-borrows
to
main
August 18, 2023 18:41
elliottdehn
reviewed
Aug 18, 2023
elliottdehn
approved these changes
Aug 18, 2023
elliottdehn
deleted the
eco-379-check-encoded-order-price-vs-lookup-key
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chen-robert
This PR adds a check for an order's price field against its corresponding AVL queue insertion key, during price level computation.
A failure test is included.
This PR is branched from #428, and should be merged after it merges