[ECO-1055] make processor easly restartable #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
alnoki
requested changes
Dec 18, 2023
There was a problem hiding this comment.
Given that #658 will require the new config style, it probably makes sense to
- Address comments
- Get this merged to
v1.5.0 - Merge
v1.5.0into [ECO-977] Add tables needed for liquidity analytics #658 - Merge [ECO-977] Add tables needed for liquidity analytics #658 into
v1.5.0 - Add a docs PR into
v1.5.0as described at [ECO-1055] make processor easly restartable #659 (comment) (I've created ECO-1080 to track this)
alnoki
approved these changes
Dec 19, 2023
alnoki
reviewed
Dec 21, 2023
Comment on lines
+18
to
+19
| if [ -s "out.csv" ];then | ||
| export STARTING_VERSION=$(cut -d, -f2 /app/out.csv) |
There was a problem hiding this comment.
This should be [ -s "/app/out.csv" ]
Will fix in #657
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the processor restartable by getting the latest indexed txn from the db on startup.
Also copy instead of mount the config file.