Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restart option and postgrest max row environment #699

Merged
merged 4 commits into from Feb 16, 2024

Conversation

harrier999
Copy link
Contributor

To resolve a few issues that arose while operating the node, added several options to the docker-compose file.

  1. Add option restart: unless-stopped to

    1. aggregator
    2. postgrest
    3. ws
    4. processor
  2. Add enviroment value PGRST_DB_MAX_ROWS:500 to postgrest

@CRBl69
Copy link
Collaborator

CRBl69 commented Feb 14, 2024

Hi. Thank you for the PR. I think the restart flag is a good idea 👍

As for PGRST_DB_MAX_ROWS, you about putting this into an env variable called POSTGREST_MAX_ROWS ? This could then be set in the .env file, along side other env variables.

Copy link
Member

@alnoki alnoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harrier999 thank you for your contribution!

I've requested two minor changes that should make for an easier UX

src/docker/compose.dss-global.yaml Outdated Show resolved Hide resolved
src/docker/compose.dss-core.yaml Outdated Show resolved Hide resolved
@harrier999
Copy link
Contributor Author

Thank you for your feedback, everyone!
I have incorporated your feedback. Could you please review it?

@alnoki
Copy link
Member

alnoki commented Feb 16, 2024

@harrier999 thank you for your contribution and for a prompt resolution to review comments!

@alnoki alnoki merged commit 0470e34 into econia-labs:main Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants