Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Superfluous upper bound on libnacl? #21

Closed
cjwatson opened this issue May 27, 2016 · 1 comment
Closed

Superfluous upper bound on libnacl? #21

cjwatson opened this issue May 27, 2016 · 1 comment

Comments

@cjwatson
Copy link

pymacaroons declares libnacl>=1.3.6,<1.4 in install_requires, but the functional tests seem to pass just fine with libnacl 1.4.5. Is the upper bound here superfluous, or can it at least be bumped? I don't see anything in the changes for libnacl 1.4.0 that would indicate a compatibility break.
@ecordell
Copy link
Owner

Happy to bump it if the tests are passing - I pin to a small range to limit possible incompatibilities. I'll get to it tonight or I'm happy to merge a PR before then if you're willing to issue one.

@cjwatson cjwatson mentioned this issue May 25, 2017
Merged
@panlinux panlinux mentioned this issue Apr 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ecordell @cjwatson