[omnibox] Add company entity feature flag.

Bug: 1366109 Change-Id: If24ae6cf3ec0e65ca8bac2565ec28455b409d7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4903598 Reviewed-by: Khalid Peer <khalidpeer@chromium.org> Commit-Queue: Jennifer Serrano <jennserrano@google.com> Cr-Commit-Position: refs/heads/main@{#1204232}
ecosia · Oct 2, 2023 · 905e8bd · 905e8bd
1 parent 81d6b73
commit 905e8bd
Show file tree

Hide file tree

Showing 7 changed files with 27 additions and 0 deletions.
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
@@ -6479,6 +6479,11 @@ const FeatureEntry kFeatureEntries[] = {
      flag_descriptions::kOmniboxGroupingFrameworkDescription, kOsAll,
      FEATURE_VALUE_TYPE(omnibox::kGroupingFrameworkForNonZPS)},
 
+    {"omnibox-company-entity-icon-adjustment",
+     flag_descriptions::kOmniboxCompanyEntityIconAdjustmentName,
+     flag_descriptions::kOmniboxCompanyEntityIconAdjustmentDescription,
+     kOsDesktop, FEATURE_VALUE_TYPE(omnibox::kCompanyEntityIconAdjustment)},
+
     {"optimization-guide-debug-logs",
      flag_descriptions::kOptimizationGuideDebugLogsName,
      flag_descriptions::kOptimizationGuideDebugLogsDescription, kOsAll,

diff --git a/chrome/browser/flag-metadata.json b/chrome/browser/flag-metadata.json
@@ -6051,6 +6051,11 @@
     "owners": ["manukh", "chrome-omnibox-team@google.com"],
     "expiry_milestone": 125
   },
+  {
+    "name": "omnibox-company-entity-icon-adjustment",
+    "owners": ["jennserrano@google.com", "khalidpeer", "chrome-omnibox-team@google.com"],
+    "expiry_milestone": 125
+  },
   {
     "name": "omnibox-consumes-ime-insets",
     "owners": ["pnoland", "chrome-omnibox-team@google.com"],

diff --git a/chrome/browser/flag_descriptions.cc b/chrome/browser/flag_descriptions.cc
@@ -2306,6 +2306,12 @@ const char kOmniboxCalcProviderName[] = "Omnibox calc provider";
 const char kOmniboxCalcProviderDescription[] =
     "When enabled, suggests recent calculator results in the omnibox.";
 
+const char kOmniboxCompanyEntityIconAdjustmentName[] =
+    "Omnibox Company Entity Icon Adjustment";
+const char kOmniboxCompanyEntityIconAdjustmentDescription[] =
+    "When enabled, company entity icons may be replaced based on the search "
+    "suggestions and their corresponding order.";
+
 const char kOmniboxCR23ActionChipsName[] = "Omnibox CR 2023 Action Chips";
 const char kOmniboxCR23ActionChipsDescription[] =
     "Updates Omnibox Action Chips to comply with CR23 shape guidelines.";

diff --git a/chrome/browser/flag_descriptions.h b/chrome/browser/flag_descriptions.h
@@ -1313,6 +1313,9 @@ extern const char kOmniboxCacheSuggestionResourcesDescription[];
 extern const char kOmniboxCalcProviderName[];
 extern const char kOmniboxCalcProviderDescription[];
 
+extern const char kOmniboxCompanyEntityIconAdjustmentName[];
+extern const char kOmniboxCompanyEntityIconAdjustmentDescription[];
+
 extern const char kOmniboxConsumesImeInsetsName[];
 extern const char kOmniboxConsumesImeInsetsDescription[];
 

diff --git a/components/omnibox/common/omnibox_features.cc b/components/omnibox/common/omnibox_features.cc
@@ -284,6 +284,11 @@ BASE_FEATURE(kSuppressClipboardSuggestionAfterFirstUsed,
              "SuppressClipboardSuggestionAfterFirstUsed",
              base::FEATURE_DISABLED_BY_DEFAULT);
 
+// If enabled, company entity icons may be replaced by a search loupe.
+BASE_FEATURE(kCompanyEntityIconAdjustment,
+             "CompanyEntityIconAdjustment",
+             base::FEATURE_DISABLED_BY_DEFAULT);
+
 // If enabled, uses the Chrome Refresh 2023 design's shape for action chips in
 // the omnibox suggestion popup.
 BASE_FEATURE(kCr2023ActionChips,

diff --git a/components/omnibox/common/omnibox_features.h b/components/omnibox/common/omnibox_features.h
@@ -80,6 +80,7 @@ BASE_DECLARE_FEATURE(kPrefBasedDataCollectionConsentHelper);
 BASE_DECLARE_FEATURE(kAdaptiveSuggestionsCount);
 BASE_DECLARE_FEATURE(kClipboardSuggestionContentHidden);
 BASE_DECLARE_FEATURE(kSuppressClipboardSuggestionAfterFirstUsed);
+BASE_DECLARE_FEATURE(kCompanyEntityIconAdjustment);
 BASE_DECLARE_FEATURE(kCr2023ActionChips);
 BASE_DECLARE_FEATURE(kCr2023ActionChipsIcons);
 BASE_DECLARE_FEATURE(kSuggestionAnswersColorReverse);

diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml
@@ -66726,6 +66726,7 @@ from previous Chrome versions.
   <int value="782167080" label="enable-new-qp-input-view"/>
   <int value="783270752" label="AndroidHistoryManager:enabled"/>
   <int value="783443490" label="ArcInputOverlayBeta:enabled"/>
+  <int value="784664314" label="CompanyEntityIconAdjustment:disabled"/>
   <int value="784856302" label="EnableBorderlessPrinting:disabled"/>
   <int value="785273919" label="CompositingBasedThrottling:disabled"/>
   <int value="785795587" label="AndroidAppIntegrationSafeSearch:enabled"/>
@@ -67983,6 +67984,7 @@ from previous Chrome versions.
   <int value="1413948819" label="NupPrinting:enabled"/>
   <int value="1414652547" label="LinkCapturingAutoDisplayIntentPicker:enabled"/>
   <int value="1414918327" label="enable-accelerated-video-decode"/>
+  <int value="1416395000" label="CompanyEntityIconAdjustment:enabled"/>
   <int value="1416592483" label="ash-enable-mirrored-screen"/>
   <int value="1416845437" label="InstallPromptSegmentation:disabled"/>
   <int value="1416970206" label="ArcGameModeFeature:disabled"/>