Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer.json for SF7 #98

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

StudioAH
Copy link

@StudioAH StudioAH commented Feb 20, 2024

dependencies updates for symfony 7

This PR

  • [x]
  • [ ]
  • [ ]

Follows #. Related to #97. Fixes #.

dependencies updates for symfony 7
Copy link
Member

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

Do you think making it compatible with Symfony 6 and 7 would be a good idea ?

@StudioAH
Copy link
Author

Hi, previous version was already compatible with Symfony 6 so why not following up with 7 ?

@StudioAH StudioAH closed this Feb 20, 2024
@drupol
Copy link
Member

drupol commented Feb 20, 2024

Hello,

Why did you close the PR ?

FYI, I received a request for making it compatible with SF7 yesterday, I gave more information in the issue itself at #97

@StudioAH
Copy link
Author

StudioAH commented Feb 20, 2024

Hello, No testing was done for both SF 6 & 7 and the code had to be changed. Therefore I wanted to make sure this would work. But if you want to work on it be my guest because I am struggling to test it locally atm.

@drupol
Copy link
Member

drupol commented Feb 20, 2024

I'm confused.

If you open a PR against this project, I guess that's because you want some stuff to be updated in it, right?

@StudioAH
Copy link
Author

Yes but your comment was right, my code was not considering the bundle to work for both symfony 6 and 7 at the same time. It needed some changes ^6.0 | ^7.0 for exemple

@drupol
Copy link
Member

drupol commented Feb 20, 2024

OK OK !

Yeah if you could reopen your PR and update to ^6.0 || ^7.0 (mind the 2 |), it could be nice, so you could tell me if it works, and if it is successful, I can cut a release and also close the aforementionned issue!

@StudioAH StudioAH reopened this Feb 20, 2024
6+7 dependencies
composer.json Outdated Show resolved Hide resolved
Copy link
Member

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also use ^6.1 in place of ^6.0 ?

@StudioAH StudioAH requested a review from drupol February 20, 2024 10:09
@drupol
Copy link
Member

drupol commented Feb 20, 2024

Nice! Thank you very much.

@Punt13140 Do you mind testing that branch and see if it works on your side? In case of a yes, I'll cut a new release immediately.

@StudioAH No worries about the broken tests, I'll take care of it myself.

@Punt13140
Copy link

I quickly tried to install the bundle in a new Symfony 7 project, and it doesn't work out of the box.

I have dependency problems with

"psr/http-message": "^1.0",

Trying to change

"psr/http-message": "^1.0|^2.0",

We have another dependency problem with

loophp/psr-http-message-bridge-bundle

which depends on
"symfony/psr-http-message-bridge": "^1 || ^2"

However, it seems that the latter now follows Symfony tags since 6.4...

Import the bridge into the Symfony monorepo and synchronize releases
https://github.com/symfony/psr-http-message-bridge/blob/v6.4.3/CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants