Fix button down detection #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm guessing du.ino was changed recently, because this button detection logic was wrong in two different ways: - m[1] is actually a 2 character string, so comparing it to '0' and '1' will always fail - it had the values for up and down reversed. It makes sense that 1 be down and 0 be up, but I'm not sure where you want the fix for the two character value.
|
Hey man, good catch. I waited to push the C changes to NPM because I thought something like this would come up and I didn't have time to test everything when I merged. I'll add you as a contributor 👍 |
ecto
pushed a commit
that referenced
this pull request
Mar 2, 2012
[minor] Fix button down detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm guessing du.ino was changed recently, because the button.js state detection logic was wrong in two different ways:
It makes sense that 1 be down and 0 be up, but I'm not sure where you want the fix for the two character value.